aleksandar-trajkovic-db commented on code in PR #59671:
URL: https://github.com/apache/spark/pull/59671#discussion_r4423634923
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -154,8 +154,7 @@ class JDBCTableCatalog extends TableCatalog
override def loadTable(ident: Identifier): Table = {
JdbcUtils.withConnection(options) { conn =>
val tableOptions = new JDBCOptions(
- options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)) +
- (JDBCOptions.JDBC_TIMESTAMP_NTZ_WALL_CLOCK ->
dialect.timestampNTZAsWallClock.toString))
+ options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)))
Review Comment:
Yes, if the user sets a catalog option, it has priority. If it's not set, we
use the default which is the legacy Spark conf. The default for the conf is new
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
