shenavaa commented on PR #59953: URL: https://github.com/apache/spark/pull/59953#issuecomment-6534472623
@jerrypeng thanks, sorry I didn't know your pr was there and looks solid. One thing to add. In RocksDB (snapshot iterators), a key that is expired at iterator-open time can be refreshed by a non-late record earlier in the same batch. Without re-reading the current value before remove, the stale snapshot entry gets evicted and there could be a later incorrect duplicate. With this one I have a test that fails without the re-read. Could we adopt the re-read and ideally the logical-expiry check here, or see if the shared path already handles it? Maybe we can add an extra test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
