viirya commented on code in PR #110: URL: https://github.com/apache/spark-connect-rust/pull/110#discussion_r4431034593
########## python/tests/day_time_interval_cases.py: ########## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""SPARK-60607: exact day-time interval results, without a JVM. + +The small gRPC fixture sends real Arrow IPC and just the protobuf envelopes +needed by these tests. It does not depend on the reference PySpark package +(which occupies the same import namespace as this client). + +Envelopes and logical types are generated from the vendored Spark Connect protos +using protoc, which is also required to build the Rust client. +""" + +from concurrent.futures import ThreadPoolExecutor +from datetime import timedelta +import unittest +import os +from pathlib import Path +import shutil +import subprocess +import tempfile + +from google.protobuf import descriptor_pb2, descriptor_pool, message_factory Review Comment: This import isn't guarded like `grpc`/`pyarrow`, and `test_dropin_offline.py` imports this module at the top, so without `protobuf` the whole offline suite fails at collection instead of skipping these tests. Can it move into the existing `try` block? Likewise, a missing `protoc` (line 52) should `skipTest` rather than raise `RuntimeError`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
