metanil commented on code in PR #59760:
URL: https://github.com/apache/spark/pull/59760#discussion_r4432844370
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -2570,8 +2592,8 @@ case class KeyedShuffleSpec(
// `createPartitioning` replaces a transform's argument with the other
child's cluster key,
// which drops whatever surrounds the key, e.g. the `+ 1` of
`bucket(4, b + 1)` or the `.a`
// of `bucket(4, s.a)`. Such a spec's own child would then be laid out
differently from the
- // children shuffled onto it.
- case t: TransformExpression => argumentsAreColumns(t)
+ // children shuffled onto it. Those children are routed by evaluating
it, too.
+ case t: TransformExpression => argumentsAreColumns(t) && canEvaluate(t)
Review Comment:
`canCreatePartitioning` doesn't evaluate anything any more, so it never
reaches the `reducedWith` arm, and the doc holds again.
The check is now done by `canEvaluatePartitioning`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
