dbtsai commented on PR #131: URL: https://github.com/apache/spark-connect-rust/pull/131#issuecomment-6549976923
@viirya Addressed the review and inline comments in local commit `f807ba5`: - Rust `DataFrame::print_schema()` now prints the shared schema tree renderer. Python keeps `builtins.print` for stdout capture. - `printSchema` and `StructType.treeString` share depth normalization, including fractional and huge values. Their distinct falsey-argument behavior matches reference, and `treeString` keeps its existing default signature. - The description now explains the fixture scope change: both test groups share one process to avoid repeated Python/gRPC startup, with per-test server resets and fresh DataFrames keeping caches isolated. The renderer docs/helper/allocation changes and the reduced test cases are included too. Local validation passed: 331 offline Python tests, 398 Rust library tests, 13 type tests, and compilation of all client test targets with and without `wasm-udf`. Reference PySpark 4.2.0 matched the depth, signature and escaping checks. Workspace and binding Clippy still report existing errors; the source audit found none on changed lines. I’m pushing this follow-up next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
