SavicStefan commented on code in PR #59927:
URL: https://github.com/apache/spark/pull/59927#discussion_r4444428252
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionSuite.scala:
##########
@@ -1468,6 +1468,101 @@ class VariantExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
/* offset list */ 0, 2,
/* field data: INT8 with only 1 byte */ primitiveHeader(INT8), 0),
metadata)
+ // Malformed containers: the final offset is missing. A container with n
children requires
+ // n + 1 offsets, so even an empty container requires one.
+ invalid(Array(arrayHeader(false, 1),
+ /* size */ 0))
+ invalid(Array(objectHeader(false, 1, 1),
+ /* size */ 0))
+ invalid(Array(arrayHeader(false, 4),
+ /* size */ 0,
+ /* truncated offset list */ 0, 0))
+ valid(Array(arrayHeader(false, 4),
+ /* size */ 0,
+ /* offset list */ 0, 0, 0, 0))
+ invalid(Array(arrayHeader(true, 1),
+ /* size */ 0, 0, 0, 0))
+ valid(Array(arrayHeader(true, 1),
+ /* size */ 0, 0, 0, 0,
+ /* offset list */ 0))
+ invalid(Array(arrayHeader(false, 1),
+ /* size */ 1,
+ /* offset list */ 0, 2,
+ /* element data: empty array without its offset list */
arrayHeader(false, 1), 0))
+
+ // Malformed containers: the final offset points past the end of the value.
+ invalid(Array(arrayHeader(false, 1),
Review Comment:
Added them, we need also to sure that we tests that path. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
