sankalpsthakur commented on code in PR #949: URL: https://github.com/apache/spark-kubernetes-operator/pull/949#discussion_r4439349083
########## docs/migration_guide.md: ########## @@ -125,9 +125,23 @@ affect building the project, CI, tests or examples. `kubernetes_client_http_response_latency_seconds_sum`, is the sum of all recorded values. 1.0 exported the mean of roughly the last 5 minutes multiplied by the count instead, which can decrease between scrapes, so `rate()` of it and the average derived from it were wrong. Also, the - `0.5` and `0.999` quantiles of the `operator_sdk_*` histograms are the median and the 99.9th + `0.5` and `0.999` quantiles of the operator histograms and timers are the median and the 99.9th Review Comment: with histograms again, the `operator_sdk_*` histograms exist in 1.1 too, and in 1.0 their `0.5` and `0.999` quantiles were the mean and the 99th percentile, so i restored this sentence as it is on main ########## docs/migration_guide.md: ########## @@ -125,9 +125,23 @@ affect building the project, CI, tests or examples. `kubernetes_client_http_response_latency_seconds_sum`, is the sum of all recorded values. 1.0 exported the mean of roughly the last 5 minutes multiplied by the count instead, which can decrease between scrapes, so `rate()` of it and the average derived from it were wrong. Also, the - `0.5` and `0.999` quantiles of the `operator_sdk_*` histograms are the median and the 99.9th + `0.5` and `0.999` quantiles of the operator histograms and timers are the median and the 99.9th percentile instead of the mean and the 99th percentile. A histogram or timer of a custom metrics source has no `_sum` unless it is a `SummingHistogram` or a `SummingTimer`. +- Since 1.1.0, the `operator.sdk` metrics source times the controller executions, i.e. the + reconciliations and cleanups, with timers instead of histograms, so the source has no histograms + anymore. The timers record nanoseconds. 1.0 recorded whole seconds, so an execution under one + second, which most are, was recorded as `0`, and the quantiles and `_sum` of these histograms + were mostly `0`. With the default text-based Prometheus format, the timers are exported in + seconds with a `_duration_seconds` suffix regardless of + `spark.kubernetes.operator.metrics.sanitizePrometheusMetricsNameEnabled`, e.g. + `operator_sdk_sparkapplication_sparkappreconciler_reconcile_both_duration_seconds` instead of + `operator_sdk_sparkapplication_sparkappreconciler_reconcile_both`, plus `_m1_rate`, `_m5_rate` Review Comment: thanks, the example is `operator_sdk_sparkapplication_sparkappreconciler_reconcile_resource` now. since the names don't change anymore, it's the only name left in the item ########## docs/migration_guide.md: ########## @@ -125,9 +125,23 @@ affect building the project, CI, tests or examples. `kubernetes_client_http_response_latency_seconds_sum`, is the sum of all recorded values. 1.0 exported the mean of roughly the last 5 minutes multiplied by the count instead, which can decrease between scrapes, so `rate()` of it and the average derived from it were wrong. Also, the - `0.5` and `0.999` quantiles of the `operator_sdk_*` histograms are the median and the 99.9th + `0.5` and `0.999` quantiles of the operator histograms and timers are the median and the 99.9th percentile instead of the mean and the 99th percentile. A histogram or timer of a custom metrics source has no `_sum` unless it is a `SummingHistogram` or a `SummingTimer`. +- Since 1.1.0, the `operator.sdk` metrics source times the controller executions, i.e. the + reconciliations and cleanups, with timers instead of histograms, so the source has no histograms + anymore. The timers record nanoseconds. 1.0 recorded whole seconds, so an execution under one + second, which most are, was recorded as `0`, and the quantiles and `_sum` of these histograms + were mostly `0`. With the default text-based Prometheus format, the timers are exported in + seconds with a `_duration_seconds` suffix regardless of + `spark.kubernetes.operator.metrics.sanitizePrometheusMetricsNameEnabled`, e.g. + `operator_sdk_sparkapplication_sparkappreconciler_reconcile_both_duration_seconds` instead of + `operator_sdk_sparkapplication_sparkappreconciler_reconcile_both`, plus `_m1_rate`, `_m5_rate` + and `_m15_rate` gauges per timer. With Review Comment: with histograms, `_count`, `_sum` and the quantiles keep their 1.0 names, so only the values change, which the item says now. the one exception is a namespace containing `nanos`, which 1.0 renamed to `_seconds`, and the item mentions it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
