lisancao commented on code in PR #59613: URL: https://github.com/apache/spark/pull/59613#discussion_r4449019298
########## docs/spark-connect-server-libs.md: ########## @@ -137,16 +72,19 @@ A Spark Server Library consists of the following components, illustrated in Fig. 4. The client package that exposes the Spark Server Library application logic to the Spark Client Application, alongside PySpark or the Scala Spark Client. <p style="text-align: center;"> - <img src="img/extending-spark-connect-labelled.png" title="Figure 2: Labelled Architecture" alt="Extending Spark -Connect Diagram - Labelled Steps"/> -</p> + <img + src="img/extending-spark-connect-labelled.png" + alt="Extending Spark Connect Diagram - Labelled Steps" + /> + <figcaption style="text-align: center;">Figure 2: Labelled Architecture</figcaption> Review Comment: It's the other way around from how the diff reads, sorry for the confusion. The page keeps the labelled one: the first figure's `src` now points at `img/extending-spark-connect-labelled.png` (it kept the first figure's alt text and caption, which is why the diff looks like the labelled block went away), and the second `<p>` block is the one removed. The file deleted in feb75ffba01 is the unlabelled `img/extending-spark-connect.png`; `extending-spark-connect-labelled.png` is the only one left in `docs/img`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
