Raviston6296 commented on PR #60017: URL: https://github.com/apache/spark/pull/60017#issuecomment-6576012881
Thanks @pan3793! branch-4.0 has the same `LogicalQueryStage.maxRows`, and the `branch-4.1` commit from #60018 cherry-picks cleanly onto branch-4.0. I checked it locally on branch-4.0: - Without the fix, the new SPARK-57956 test fails (`Some(0) did not contain 2`); with it, the test passes. - SPARK-36424 still passes. - The query from #59434 returns 3 rows in all 200 runs on branch-4.0 both with and without the fix, so that particular query doesn't trigger it there, but the underlying issue is the same. So #60018 can be merged into branch-4.0 as well. I can open a separate 4.0 PR instead if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
