dongjoon-hyun commented on code in PR #60049:
URL: https://github.com/apache/spark/pull/60049#discussion_r4452088869
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##########
@@ -261,9 +262,15 @@ object PROCESS_TABLES extends QueryTest {
val isPythonVersionAvailable = TestUtils.isPythonVersionAvailable
val releaseMirror = sys.env.getOrElse("SPARK_RELEASE_MIRROR",
"https://dist.apache.org/repos/dist/release";)
- // Tests the latest version of every release line if Java version is at most
17.
+ val javaVersion = Runtime.version().feature()
+ // Spark 3.3, 4.0, and 4.2 are the first release lines that support Java 17,
21, and 25,
+ // respectively. No release line supports the other Java versions, e.g.,
Java 26. Add an entry
+ // here when a Spark release adds a Java version to its `docs/index.md`.
+ val minimumTestingVersion: Option[String] =
+ Map(17 -> "3.3.0", 21 -> "4.0.0", 25 -> "4.2.0").get(javaVersion)
+ // Tests the latest version of every release line that supports the running
Java version.
val testingVersions: Seq[String] = if (isPythonVersionAvailable &&
- Utils.isJavaVersionAtMost17) {
+ minimumTestingVersion.isDefined) {
import scala.io.Source
val sparkVersionPattern = """<a href="spark-(\d.\d.\d)/">""".r
Review Comment:
That's completely independent problem. Let's not piggy-back like that,
@pan3793 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
