Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6873#discussion_r32759772
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -110,6 +110,9 @@ public ManagedBuffer getBlockData(String appId, String
execId, String blockId) {
return getHashBasedShuffleBlockData(executor, blockId);
} else if
("org.apache.spark.shuffle.sort.SortShuffleManager".equals(executor.shuffleManager))
{
return getSortBasedShuffleBlockData(executor, shuffleId, mapId,
reduceId);
+ } else if
("org.apache.spark.shuffle.unsafe.UnsafeShuffleManager".equals(
--- End diff --
this could just be merged with the previous case:
```
} else if
("org.apache.spark.shuffle.sort.SortShuffleManager".equals(executor.shuffleManager)
||
"org.apache.spark.shuffle.unsafe.UnsafeShuffleManager".equals(executor.shuffleManager))
{
return getSortBasedShuffleBlockData(...);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
