qianlan717 commented on code in PR #59982:
URL: https://github.com/apache/spark/pull/59982#discussion_r4464158012
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -601,6 +608,33 @@ private[sql] class SparkConnectClient(
*/
def preferredArrowChunkSize: Option[Int] =
configuration.preferredArrowChunkSize
+ private lazy val localIvySettingsPath: Option[String] =
+ new ConfigReader((key: String) => conf.getOption(key))
Review Comment:
We'll follow the existing Connect client pattern and read this session
setting through RuntimeConfig/Config RPC. Here, `spark.jars.ivySettings` is a
file path, so the value itself is unlikely to contain credentials; credentials
inside the XML file are not returned by Config RPC.
A directory name such as `secrets` can still match the regex. We'll preserve
the existing redaction behavior and keep the documented fallback to built-in
Ivy settings when the value is withheld. The notebook cases were manually
verified with a readable session-provided settings file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
