MaxGekk commented on PR #59984: URL: https://github.com/apache/spark/pull/59984#issuecomment-6635773505
@LuciferYang @uros-b could you review? With whole-stage codegen off, `GeneratePredicate` evaluated a subexpression shared by later conjuncts before the whole condition, so a FALSE earlier conjunct did not stop it; it now evaluates the subexpression just before the first conjunct that references it, as the `FilterExec` CSE branch from SPARK-56032 does, with the analysis still over the whole predicate and the calls in dependency order. The two blocking findings of the automated review are fixed and pinned by tests, CI is green on 358d156dde6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
