jiwen624 commented on code in PR #56558:
URL: https://github.com/apache/spark/pull/56558#discussion_r4489396875
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -90,9 +90,9 @@ protected String escapeSpecialCharsForLikePattern(String str)
{
* The default returns the input unchanged: a standard SQL string literal is
taken verbatim (the
* single-quote doubling is already applied when the literal is rendered),
so the {@code \} that
* {@link #escapeSpecialCharsForLikePattern} uses as the LIKE escape
character reaches the LIKE
- * engine intact. A dialect whose string-literal syntax gives {@code \} a
special meaning (e.g.
- * MySQL, which treats {@code \} as an escape character inside string
literals) must override this
- * to double the backslash, so the LIKE pattern survives string-literal
parsing unchanged.
+ * engine intact. A dialect whose string-literal syntax gives {@code \} a
special meaning must
Review Comment:
`JDBCSQLBuilder` is `private[jdbc]`, so only Spark's own dialects use that
path, and none override this hook. For any builder that extends
`V2ExpressionSQLBuilder` directly, the base
`visitStartsWith/visitEndsWith/visitContains` still call it, so the javadoc
stays accurate for anyone who can follow it. I'd rather not describe private
JDBC internals in this public javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
