vladanvasi-db opened a new pull request, #60171:
URL: https://github.com/apache/spark/pull/60171
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Extract command-local DDL and DML analysis from fixed-point rules into
shared helpers:
- Field names and positions for ALTER TABLE and CREATE INDEX, ALTER
validation, and partition
specification resolution and validation.
- V1/V2 INSERT preparation, write-output alignment, row-level assignment
conversion, and check
and generated-column invariant construction.
- V1 ADD/ALTER COLUMN, comment changes, CTAS/RTAS/CREATE TABLE LIKE, and
namespace creation and
location changes.
The existing rules call these helpers with the same traversal, pruning,
eligibility, case order,
and fixed-point stages. Generated-expression analysis remains an explicit
callback, including
the lazy fallback to session settings. The per-column INSERT helper accepts
a caller-owned alias
factory, and field-path resolution is callable independently of a rule
traversal.
The whole-command INSERT/write helpers retain legacy output access and may
produce expressions
that require further resolution. Future Single Pass callers must use their
cached outputs and
resolve synthesized expressions inline; this PR only extracts the shared
operations.
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Single Pass command resolvers need to reuse existing DDL/DML semantics
without invoking
fixed-point rule traversals or duplicating their implementation. This
continues the helper
extractions in #59646, #59746, #59861, #59959, and #60099.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No. This is a refactor only. SQL behavior, analyzer routing, command
coverage, configuration,
validation timing, and golden files are unchanged.
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Ran 978 tests using SBT and JDK 21; all passed:
- 503 Catalyst tests across 10 suites, covering analysis and V2 write
alignment.
- 452 SQL tests across 20 suites: `PlanResolutionSuite`,
`ResolveDefaultColumnsSuite`,
`V2CommandsCaseSensitivitySuite`, UPDATE/MERGE assignment alignment,
connector schema alignment,
generated columns, check constraints, V2 column and partition commands,
and V1/V2 namespace
creation and location changes.
- 23 focused cases for V1 ADD/CHANGE COLUMN, CHAR/VARCHAR metadata, and
column comments through
`InMemoryCatalogedDDLSuite`, `AlterTableAddColumnsSuite`,
`FileSourceCharVarcharDDLTestSuite`, and
`DataSourceV2SQLSuiteV1Filter`/`V2Filter`.
Scala style checks passed with zero errors or warnings:
```sh
build/sbt 'catalyst/scalastyle' 'catalyst/Test/scalastyle' 'sql/scalastyle'
```
The focused alias contract cases can be run with:
```sh
build/sbt 'catalyst/testOnly
org.apache.spark.sql.catalyst.analysis.AnalysisSuite -- -z "insertion column
projection"'
```
Added four cases to `AnalysisSuite` to verify that per-column INSERT
projection uses the caller's
alias factory and expression ID for scalar, struct, array, and map columns.
Existing command and
analysis suites cover the extracted semantics and error behavior.
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
