xumingming commented on PR #60054:
URL: https://github.com/apache/spark/pull/60054#issuecomment-6622251925
Thanks for the thorough review, @Raviston6296!
1. Dropped the literal `like(collate('ı', 'UTF8_LCASE'), '%i%')` assertion,
since `ConstantFolding` folds it before `LikeSimplification`, and left the
column query as the regression test.
2. Left the `asInstanceOf[StringType]` cast, since analysis has already
required a `StringType` and a failed cast is the louder failure.
3. Updated the user-facing change section to note that this turns off the
UTF8_LCASE part of SPARK-48621, so simple patterns such as `c LIKE 'abc%'` go
back to Java regex and will be slower.
4. Agreed the `LIKE` versus `=` case-mapping mismatch belongs in a follow-up
JIRA, since matching ICU lowercase would change existing `LIKE` results and
split `LIKE` from `RLIKE`, which still uses the JDK `(?ui)` flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
