Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4230#discussion_r32773483
--- Diff: core/src/test/scala/org/apache/spark/DriverSuite.scala ---
@@ -28,31 +28,30 @@ import org.apache.spark.util.Utils
class DriverSuite extends FunSuite with Timeouts {
+ // Regression test for SPARK-530: "Spark driver process doesn't exit
after finishing"
test("driver should exit after finishing") {
val sparkHome = sys.props.getOrElse("spark.test.home",
fail("spark.test.home is not set!"))
- // Regression test for SPARK-530: "Spark driver process doesn't exit
after finishing"
- val masters = Table(("master"), ("local"), ("local-cluster[2,1,512]"))
+ val masters = Table("master", "local", "local-cluster[2,1,512]")
forAll(masters) { (master: String) =>
- failAfter(60 seconds) {
- Utils.executeAndGetOutput(
- Seq(s"$sparkHome/bin/spark-class",
"org.apache.spark.DriverWithoutCleanup", master),
- new File(sparkHome),
- Map("SPARK_TESTING" -> "1", "SPARK_HOME" -> sparkHome))
- }
+ val process = Utils.executeCommand(
+ Seq(s"$sparkHome/bin/spark-class",
"org.apache.spark.DriverWithoutCleanup", master),
+ new File(sparkHome),
+ Map("SPARK_TESTING" -> "1", "SPARK_HOME" -> sparkHome))
+ failAfter(60 seconds) { process.waitFor() }
+ // Ensure we still kill the process in case it timed out
+ process.destroy()
--- End diff --
by the way I'm addressing this at #6886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
