pingedbrain commented on PR #60193: URL: https://github.com/apache/spark/pull/60193#issuecomment-6701111162
Built it locally and the fix looks good: the streaming tests pass, and the new ones fail without the fix. One thing I'd change: test_streaming_query_validation.py imports Connect at module level, so without grpcio the whole file fails, including the classic tests. PR CI won't catch it, but I think the scheduled classic-only build would. Guarding those tests with should_test_connect worked for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
