dbtsai opened a new pull request, #286: URL: https://github.com/apache/spark-connect-rust/pull/286
UDTF handlers that extend `AnalyzeResult` with a dataclass currently fail at class definition with `TypeError: type 'pyspark.sql.udtf.AnalyzeResult' is not an acceptable base type`. Official PySpark 4.3 explicitly supports these subclasses to pass custom analysis state to a handler constructor. Expose `AnalyzeResult` as a mutable Python dataclass with the same fields and defaults as PySpark. Add regression coverage for inherited dataclass fields, custom-state serialization, handler commands and live analysis-to-constructor state transfer. This inherited gap was found during the post-merge review of #119; the DDL/handler serialization patch itself remains sound. Validation: the existing family test and new subclass regression pass when their repository test bodies execute with an isolated older native helper copy and installed official PySpark 4.2 schema/serializer dependencies. The subclass regression fails as expected against the unchanged master shim. The dataclass fields match official 4.3 source exactly; Python syntax and `git diff --check` pass. This is a draft pending required validation and review. The exact-current native extension, full offline/official parity suites and live Spark 4.3 test were not run. Cargo/rustc/protoc are absent; the campaign lock wrapper reaches a missing-Cargo failure. Mandatory genuine Claude review remains incomplete: the initial gateway call failed before review, and automatic approval rejected the network retry pending explicit source/destination approval. A separate Codex review covers the complete follow-up patch, but is not a claim that the required Claude review completed. This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
