viirya commented on code in PR #60195:
URL: https://github.com/apache/spark/pull/60195#discussion_r4500469437
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala:
##########
@@ -599,7 +606,7 @@ private[execution] final class LongToUnsafeRowMap(
}
}
- init()
+ if (allocateOnInit) init()
Review Comment:
Optional, not from this PR: with this flag, the `if (mm != null)` guard
inside `init()` can no longer be false. It was already unreachable, because
`MemoryConsumer`'s constructor calls `mm.getTungstenMemoryMode` first. It could
be dropped here, or left as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
