dbtsai opened a new pull request, #284: URL: https://github.com/apache/spark-connect-rust/pull/284
### What changes were proposed in this pull request? Harden the loopback gRPC cleanup tests from #172. Capture initial execution and reattach requests and verify their identity, request options, authentication and custom headers. Add disconnected-cursor and permanent reattach-failure coverage, give scenarios independent test names, bound the outside-runtime Drop wait, and report excess release counts directly. ### Why are the changes needed? These assertions cover previously unobserved request headers and cleanup failure paths. The fixture also reports a stuck Drop or an excess release count more clearly. ### Does this PR introduce _any_ user-facing change? No. The patch changes one integration-test file. ### How was this patch tested? - `git diff --check`: passed. - Genuine local Claude Code reviewed the complete follow-up over four rounds. Codex fixed worthwhile findings; the final whole-patch review reports no actionable source finding. Three final style suggestions are accepted nonblocking nits. - Focused `reattach_cleanup` tests and `cargo fmt --all --check` were attempted through the campaign Cargo lock. Both failed before Cargo launch because this host has no Cargo/Rust toolchain. - Required compilation, formatting, tests, Clippy and Python parity/official-test checks remain pending. This PR stays draft; no executed test pass or review-and-validation convergence is claimed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-6), with Claude Code 2.1.314 for review. This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
