dbtsai opened a new pull request, #292:
URL: https://github.com/apache/spark-connect-rust/pull/292

   ### What changes were proposed in this pull request?
   
   The three day-time interval live tests added by #116 are absent from the 
live CI test collection. Import `IntervalInputLiveTests` into the existing live 
suite, so the current CI command covers inferred and explicit inputs, nested 
values, nulls and collected-row round trips. Also assert the decoded row count 
before comparing interval IPC rows, so truncation cannot pass the unit test. 
Clean up the three offline sessions so the cases are self-contained when run 
directly with unittest, and remove a stale comment that still marks interval 
input as pending.
   
   ### Why are the changes needed?
   
   Follow-up to 
[SPARK-60659](https://issues.apache.org/jira/browse/SPARK-60659) / #116. The 
interval cases module is not named for pytest discovery, and only its 
conversion class was registered in the offline suite.
   
   ### Does this PR introduce any user-facing change?
   
   No. Test coverage only.
   
   ### How was this patch tested?
   
   - Test collection on the current base: 105 tests and no interval live cases; 
with this patch: 108 tests including all three interval live cases. The tests 
skip when no server is configured. This check used installed PySpark 4.2 only 
to import/collect the tests, not to claim Spark 4.3 behavior.
   - Python syntax checks, `git diff --check`, and the no-stub audit pass.
   - Genuine local Claude Code reviewed the landed patch and the complete final 
four-file follow-up. No actionable source findings remain; every finding and 
nit was assessed.
   - Draft: required Rust checks, native-extension tests, live Spark 4.3 tests 
and the official parity gate remain pending. The local host has no Rust 
toolchain. A campaign-lock-wrapped Cargo test stopped before compilation 
because `cargo` is unavailable.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (GPT-6).
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to