Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6866#discussion_r32782416
--- Diff: dev/run-tests.py ---
@@ -505,16 +638,25 @@ def main():
print "[info] Using build tool", build_tool, "with profile",
hadoop_version,
print "under environment", test_env
- # determine high level changes
- changed_modules = identify_changed_modules(test_env)
- print "[info] Found the following changed modules:", ",
".join(changed_modules)
+ changed_modules = None
+ if test_env == "amplab_jenkins" and os.environ.get("AMP_JENKINS_PRB"):
+ target_branch = os.environ["ghprbTargetBranch"]
+ changed_modules = identify_changed_modules_from_git_commits("HEAD",
+
target_branch=target_branch)
+ if not changed_modules:
+ changed_modules = [root]
+ print "[info] Found the following changed modules:", ", ".join(x.name
for x in changed_modules)
+
+ test_modules = determine_modules_to_test(changed_modules)
# license checks
run_apache_rat_checks()
# style checks
- run_scala_style_checks()
- run_python_style_checks()
+ if changed_modules != [docs]:
+ run_scala_style_checks()
+ if any(m.should_run_python_tests for m in changed_modules):
--- End diff --
Should we check that any modified path is ending with `.py`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
