Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6874#discussion_r32804286
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
 ---
    @@ -79,3 +78,42 @@ case class CreateStruct(children: Seq[Expression]) 
extends Expression {
         InternalRow(children.map(_.eval(input)): _*)
       }
     }
    +
    +/**
    + * Creates a struct with the given field names and values
    + *
    + * @param children Seq(name1, val1, name2, val2, ...)
    + */
    +case class CreateNamedStruct(children: Seq[Expression]) extends Expression 
{
    +  assert(children.size % 2 == 0, "NamedStruct expects an even number of 
arguments.")
    --- End diff --
    
    yes, please use `checkInputTypes` here to check `children.size % 2 == 0` 
and all name expressions are non-null literal string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to