Github user suyanNone commented on a diff in the pull request:
https://github.com/apache/spark/pull/4887#discussion_r32811415
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -295,9 +296,9 @@ private[spark] class MemoryStore(blockManager:
BlockManager, maxMemory: Long)
// In this case, we should release the memory after we cache the
block there.
// Otherwise, if we return an iterator, we release the memory
reserved here
// later when the task finishes.
- if (keepUnrolling) {
- accountingLock.synchronized {
- val amountToRelease = currentUnrollMemoryForThisThread -
previousMemoryReserved
+ accountingLock.synchronized {
--- End diff --
@srowen releasePendingUnrollMemoryForThisThread means: we will reserved the
unroll memory reserved for the unroll block, we need to release that part of
memory when we not use any more, like: we put the unroll successful block to
memoryStore, or we put unroll unsuccessful block into the disk, or we complete
the task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
