Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6893#discussion_r32853807
--- Diff:
core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala ---
@@ -164,12 +164,20 @@ private[ui] object RDDOperationGraph extends Logging {
*
* For the complete DOT specification, see
http://www.graphviz.org/Documentation/dotguide.pdf.
*/
- def makeDotFile(graph: RDDOperationGraph): String = {
+ def makeDotFile(graph: RDDOperationGraph, stageId: String): String = {
val dotFile = new StringBuilder
dotFile.append("digraph G {\n")
- dotFile.append(makeDotSubgraph(graph.rootCluster, indent = " "))
- graph.edges.foreach { edge => dotFile.append(s"""
${edge.fromId}->${edge.toId};\n""") }
- dotFile.append("}")
+ try {
+ dotFile.append(makeDotSubgraph(graph.rootCluster, indent = " "))
+ graph.edges.foreach { edge => dotFile.append(s"""
${edge.fromId}->${edge.toId};\n""") }
+ dotFile.append("}")
+ } catch {
+ case t: Throwable =>
--- End diff --
@XuTingJun, if an OOM happens then there's nothing we can do. In general we
should not try to catch OOMs; instead we should prevent it in the first place
if possible. Elsewhere in Spark we never catch `Throwable`, but only
`NonFatal(e)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
