Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6759#discussion_r32857204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -17,18 +17,25 @@
package org.apache.spark.sql.catalyst.util
-import java.sql.{Timestamp, Date}
+import java.sql.{Date, Timestamp}
import java.text.SimpleDateFormat
import java.util.{Calendar, TimeZone}
import org.apache.spark.sql.catalyst.expressions.Cast
/**
- * Helper function to convert between Int value of days since 1970-01-01
and java.sql.Date
+ * Helper function to convert between Int value of days since epoch and
java.sql.Date,
--- End diff --
I think that we should re-word this slightly. I'd say something like this
(provided it's accurate):
> Helper functions for converting between internal and external date and
time representations.
>
> Dates are exposed externally as java.sql.Date and are represented
internally as the number of dates since the Unix epoch (1970-01-01).
Timestamps are exposed externally as java.sql.Timestamp and are stored
internally as longs, which are capable of storing timestamps with 100
nanosecond precision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
