Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6882#discussion_r32858636
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
 ---
    @@ -173,7 +171,13 @@ case class ScriptTransformation(
               }
               outputStream.close()
             }
    -      }).start()
    +      }, "Thread-ScriptTransformation-Feed").start()
    +
    +      // Consume the error stream from the pipeline, otherwise it will be 
blocked if
    +      // the pipeline is full.
    +      new RedirectThread(errorStream, // input stream from the pipeline
    +        new CircularBuffer(),         // output to a circular buffer
    --- End diff --
    
    Shouldn't we hold on to this and print it if the forked program exits with 
a non-zero exit code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to