Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6912#discussion_r32880332
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala ---
    @@ -136,12 +137,63 @@ private[hive] class ClientWrapper(
     
       // TODO: should be a def?s
       // When we create this val client, the HiveConf of it (conf) is the one 
associated with state.
    -  private val client = Hive.get(conf)
    +  @GuardedBy("this")
    +  private var client = Hive.get(conf)
    +
    +  // We use hive's conf for compatibility.
    +  private val retryLimit = 
conf.getIntVar(HiveConf.ConfVars.METASTORETHRIFTFAILURERETRIES)
    +  private val retryDelayMillis = 1000 * conf.getIntVar(
    +    HiveConf.ConfVars.METASTORE_CLIENT_CONNECT_RETRY_DELAY)
    --- End diff --
    
    oh, Hive 0.14 changed it to
    ```
    
METASTORE_CLIENT_CONNECT_RETRY_DELAY("hive.metastore.client.connect.retry.delay",
 "1s",
            new TimeValidator(TimeUnit.SECONDS),
            "Number of seconds for the client to wait between consecutive 
connection attempts"),
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to