Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6918#discussion_r32883234
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java ---
@@ -139,17 +139,22 @@ public void write(Iterator<Product2<K, V>> records)
throws IOException {
@Override
public void write(scala.collection.Iterator<Product2<K, V>> records)
throws IOException {
- boolean success = false;
try {
while (records.hasNext()) {
insertRecordIntoSorter(records.next());
}
closeAndWriteOutput();
- success = true;
- } finally {
- if (!success) {
- sorter.cleanupAfterError();
+ } catch (Exception e) {
--- End diff --
AFAIK my original intent was to also ensure that we clean up after
Throwables as well without necessarily having to catch throwable, so I think
that's why I had the slightly unclear `success` boolean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
