Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6924#issuecomment-113884873
@nssalian you don't need me specifically to review it, but I can.
There was a previous pull request for this issue, and the feedback was that
this diff doesn't expose what if anything you edited in the text? is it just a
move, or also an edit? Ideally, if it's also an edit, you'd make two commits:
one to edit and one to move. Then it's easy to browse the changes separately.
Overall I think it's still OK to honor Matei's request here and move the
text, yes. I am not sure if the help text still needs updating, but that's
beyond just a doc update right? I don't see that here. Maybe I missed the
intent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
