Github user stephenh commented on a diff in the pull request:
https://github.com/apache/spark/pull/6918#discussion_r32895711
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java ---
@@ -147,8 +150,16 @@ public void
write(scala.collection.Iterator<Product2<K, V>> records) throws IOEx
closeAndWriteOutput();
success = true;
} finally {
- if (!success) {
- sorter.cleanupAfterError();
+ if (sorter != null) {
+ try {
+ sorter.cleanupAfterError();
+ } catch (Exception e) {
--- End diff --
You could potentially use Utils.tryWithSafeFinally, which does this sort of
annoying "try/catch in a try/catch" thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
