Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/6864#discussion_r32898807
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala
---
@@ -156,6 +156,7 @@ class CommitFailureTestRelation(
context: TaskAttemptContext): OutputWriter = {
new SimpleTextOutputWriter(path, context) {
override def close(): Unit = {
+ super.close()
--- End diff --
I was thinking about S3, where a file is not actually created before the
output stream is closed (the `PUT` operation happens in
`NativeS3FsOutputStream.close()`). But `SimpleTextRelation` is only used for
local testing, so yeah, this line is not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
