Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6780#discussion_r32902049
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -106,12 +103,16 @@ case class InsertIntoHiveTable(
}
writerContainer
- .getLocalFileWriter(row, table.schema)
- .write(serializer.serialize(outputData, standardOI))
+ .getLocalFileWriter(row, schema)
+ .write(newSer(fileSinkConf.getTableInfo).serialize(outputData,
standardOI))
}
writerContainer.close()
- }
+ }: Unit
+
+ writerContainer.driverSideSetup()
+ sc.sparkContext.runJob(rdd, sc.sparkContext.clean(writeToFile))
+ writerContainer.commitJob()
--- End diff --
I made these changes to clean the closure and avoid referencing the `$out`
so that we don't need to add a lot of `@ transient`. However, it fails a test
`CliSuite.Commands using SerDe provided in --jars` with timeout. Does anybody
know the reason?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
