Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/6928#issuecomment-113992576
Thanks @holdenk -- Change looks pretty good. I just had some minor style
comments. BTW do you know if we re-use some test spark package to create a unit
test for this ? Using a real package might mean going to maven central etc.
which doesn't seem like a very good for a unit test, but I was wondering if we
had code to generat some fake test package for Scala unit tests.
cc @brkyvz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
