Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6864#discussion_r32907374
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
    @@ -417,15 +428,14 @@ private[sql] class DefaultWriterContainer(
           assert(writer != null, "OutputWriter instance should have been 
initialized")
           writer.close()
           super.commitTask()
    -    } catch {
    -      case cause: Throwable =>
    -        super.abortTask()
    -        throw new RuntimeException("Failed to commit task", cause)
    +    } catch { case cause: Throwable =>
    +      throw new RuntimeException("Failed to commit task", cause)
    --- End diff --
    
    This exception will be cached in `writeRows`, right? If so, can we add a 
comment and also explain how we will handle this exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to