GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/6937

    [SPARK-8532][SQL] In Python's DataFrameWriter, 
save/saveAsTable/json/parquet/jdbc always override mode

    https://issues.apache.org/jira/browse/SPARK-8532
    
    Since "error" is already set as the default mode in the JVM side, we will 
not set mode in Python API if the mode is "error". The reason of keeping 
"error" as the default value is to show this default value in Python doc.
    
    Also, had a quick chat with @davies, he thinks we need to keep the mode 
parameter in those methods, so users can call those save methods directly 
without using the builder pattern in Python.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark SPARK-8532

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6937
    
----
commit c40c461eaefd1d376538fb2c0e9e52550dfe1d78
Author: Yin Huai <[email protected]>
Date:   2015-06-22T17:40:03Z

    Regression test.

commit 88eb6c45cfe61f4922df90fe5fd8b555976b31a4
Author: Yin Huai <[email protected]>
Date:   2015-06-22T17:40:14Z

    If mode is "error", do not call mode method.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to