Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-114325358
Thanks for working on this! I made some style comments, mostly from stuff
you can find here:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
One thing I'll add is that we are hoping to do a pretty large refactoring
of aggregates in
[SPARK-4233](https://issues.apache.org/jira/browse/SPARK-4233). If you don't
have time to update now, it might be easier to close this for now and reopen
once that refactoring is done (hopefully in a few weeks).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
