Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6936#discussion_r33014415
  
    --- Diff: python/pyspark/context.py ---
    @@ -292,6 +292,20 @@ def version(self):
             return self._jsc.version()
     
         @property
    +    def applicationId(self):
    +        """
    +        applicationId - unique identified for the Spark Application
    --- End diff --
    
    I would try to make this docstring match the style of our other docstrings 
a bit better.  Specifically, there's not a need to say `applicationId - ` here, 
since that's clear from the method's name.
    
    Instead, I'd have this first line just read  something like this:
    
    ```
    A unique identifier for the Spark application.
    Its format depends on the scheduler implementation.
    ```
    
    I'm not sure whether we need to show the examples here, but I guess it 
doesn't necessarily hurt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to