GitHub user lee19 opened a pull request:

    https://github.com/apache/spark/pull/6953

    [SPARK-8563] [MLlib] Fixed a bug so that 
IndexedRowMatrix.computeSVD().U.numCols = k

    I'm sorry that I made https://github.com/apache/spark/pull/6949 closed by 
mistake.
    I pushed codes again.
    
    >
    There is a bug that `U.numCols() = self.nCols` in 
`IndexedRowMatrix.computeSVD()`
    It should have been `U.numCols() = k = svd.U.numCols()`
    
    >
    ```
    self = U * sigma * V.transpose
    (m x n) = (m x n) * (k x k) * (k x n) //ASIS
    -->
    (m x n) = (m x k) * (k x k) * (k x n) //TOBE
    ```
    
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lee19/spark MLlibBugfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6953
    
----
commit 83734242ee474c8fa74e5f495676a829bd99b196
Author: lee19 <[email protected]>
Date:   2015-06-23T13:23:47Z

    [SPARK-8563][MLlib] Fixed a bug so that 
IndexedRowMatrix.computeSVD().U.numCols = k

commit c2ccd89cec503a09073d84503064afaf211b9fc8
Author: lee19 <[email protected]>
Date:   2015-06-23T13:24:12Z

    Added a unit test that validates matrix sizes of svd for [SPARK-8563][MLlib]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to