Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6810#discussion_r33059434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -22,9 +22,11 @@ package org.apache.spark.sql.catalyst.expressions
* @param expressions a sequence of expressions that determine the value
of each column of the
* output row.
*/
-class InterpretedProjection(expressions: Seq[Expression]) extends
Projection {
- def this(expressions: Seq[Expression], inputSchema: Seq[Attribute]) =
- this(expressions.map(BindReferences.bindReference(_, inputSchema)))
+class InterpretedProjection(expressions: Seq[Expression], mutableRow:
Boolean = false)
+ extends Projection {
+ def this(expressions: Seq[Expression],
+ inputSchema: Seq[Attribute], mutableRow: Boolean = false) =
--- End diff --
Could you explain this `mutableRow` change? If we do need to keep it, the
style here isn't quite right; see
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide for
how to properly wrap long parameter lists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
