Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r33073912
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -159,6 +162,77 @@ public UTF8String toLowerCase() {
return UTF8String.fromString(toString().toLowerCase());
}
+ public UTF8String trim() {
+ return UTF8String.fromString(toString().trim());
--- End diff --
Do we really need the `toString()`? We just removed this for all the
comparison methods. If we implement `trim` directly, we save the object
creation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
