Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6849#discussion_r33084966
  
    --- Diff: python/pyspark/mllib/tests.py ---
    @@ -25,7 +25,8 @@
     import array as pyarray
     from time import time, sleep
     
    -from numpy import array, array_equal, zeros, inf, all, random
    +from numpy import (
    +    array, array_equal, zeros, inf, random, exp, dot, all, mean)
    --- End diff --
    
    Just curious, we don't need `(...)`, right? Btw, it is safer to write 
`import numpy as np` and then use `np.array` in the code. For example, `all` is 
a built-in method of Python. We can update this in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to