Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6822#discussion_r33107473
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -995,6 +995,22 @@ object functions {
       def expm1(columnName: String): Column = expm1(Column(columnName))
     
       /**
    +   * Computes the factorial of the given value.
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def factorial(e: Column): Column = Factorial(e.expr)
    +
    +  /**
    +   * Computes the factorial of the given column.
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def factorial(columnName: String): Column = factorial(Column(columnName))
    --- End diff --
    
    And also add the function with integer as parameter.
    ```scala
    def factorial(index: Int): Column
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to