Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33108341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -312,3 +315,90 @@ case class Logarithm(left: Expression, right:
Expression)
"""
}
}
+
+case class Round(child: Expression, scale: Expression) extends Expression {
+
+ def this(child: Expression) = {
+ this(child, Literal(0))
+ }
+
+ def children: Seq[Expression] = Seq(child, scale)
+
+ def nullable: Boolean = true
--- End diff --
it is not the end of the world to have nullable be more conservative, since
it is technically correct to be nullable. however, if there is a way to do a
more accurate way to determine nullability, we should do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
