Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6872#discussion_r33109262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -221,6 +221,60 @@ private[sql] object BinaryExpression {
def unapply(e: BinaryExpression): Option[(Expression, Expression)] =
Some((e.left, e.right))
}
+abstract class TernaryExpression extends Expression with
trees.TernaryNode[Expression] {
--- End diff --
`Ternary` is a very rare case, and probably most of the code in this class
are needed to be overrided for different `TernaryExpression`s, so how about
move the logic into the `Conv`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
