Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6956#discussion_r33177102
--- Diff: dev/run-tests.py ---
@@ -477,7 +477,12 @@ def determine_java_version(java_exe):
raw_output = subprocess.check_output([java_exe, "-version"],
stderr=subprocess.STDOUT)
- raw_version_str = raw_output.split('\n')[0] # eg 'java version
"1.8.0_25"'
+
+ raw_output_lines = raw_output.split('\n')
+
+ # find raw version string, eg 'java version "1.8.0_25"'
+ raw_version_str = next(str for str in raw_output_lines if " version "
in str)
--- End diff --
Nit: `str` is a built-in function, so using it as a variable name will lead
to spurious warnings in some Python linters. I'd just use `x` or `s` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
