Github user ankurcha commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5563#discussion_r33196477
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -171,12 +173,15 @@ private[spark] class CoarseMesosSchedulerBackend(
         synchronized {
           val filters = Filters.newBuilder().setRefuseSeconds(5).build()
     
    -      for (offer <- offers) {
    +      // filter out all the offers that do not meet constraints (if 
specified)
    +      val qualifyingOffers = filterOffersByConstraints(offers, 
slaveOfferConstraints)
    --- End diff --
    
    Thanks for that tidbit. I was indeed leaving them hanging around. Another 
thing which i noticed at: 
https://github.com/apache/spark/pull/5563/files#diff-d425d35aa23c47a62fbb538554f2f2cfR213
    
    Instead of declining offers the code replies with a `launchTasks` with no 
taskInfo. Does anyone know which one is preferred / correct / better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to