Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6959#discussion_r33197432
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -48,7 +38,15 @@
* primitive types, such as long, double, or int, we store the value
directly in the word. For
* fields with non-primitive or variable-length values, we store a
relative offset (w.r.t. the
* base address of the row) that points to the beginning of the
variable-length field, and length
- * (they are combined into a long).
+ * (they are combined into a long). For other objects, they are stored in
a pool, the indexes of
--- End diff --
The tricky part of this patch seems to be handling fast hashing / equality
checks for UnsafeRows that contain objects. Can we add a paragraph here to
explain how that works / why that's safe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
