Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6997#discussion_r33199960
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/FPGrowth.scala ---
@@ -62,13 +62,14 @@ class FPGrowthModel[Item: ClassTag](val freqItemsets:
RDD[FreqItemset[Item]]) ex
@Experimental
class FPGrowth private (
private var minSupport: Double,
- private var numPartitions: Int) extends Logging with Serializable {
+ private var numPartitions: Int,
+ private var mineSequences: Boolean) extends Logging with Serializable {
--- End diff --
`itemsets` and `sequences` are correct. The issue is that we have
`freqItemsets` in the model, no matter whether it stores unordered sets or
sequences. This may be confusing to users. I recommend renaming this variable
to something like `ordered` or `preservesOrdering`. cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
